Closed barretogustavo closed 2 years ago
Someone is attempting to deploy a commit to a Personal Account owned by @maurodesouza on Vercel.
@maurodesouza first needs to authorize it.
Hi @barretogustavo 👋
I am very grateful that you contributed to the project ❤ but your PR is not following the style guide, and there is no one issue linked too.
Consider opening an issue before working on any features/bugs with it so we can discuss the best way to resolve it, if it's really necessary, to avoid unnecessary work, etc.
About your solution, I don't think that a confimation modal is the best solution for this, maybe just a tooltip to infor or to avoid the accidental click, use the insomia's system, where you need the double click to exclude things. What do you think?
About the guide for PR, you cand find it here.
About the style guide for commit, you can find it here.
Reasons:
Problem:
When I was using the application, I clicked on the delete icon and deleted everything I had created.
Solution:
With the user experience in mind, I implemented a confirmation modal that ensures that no one will be able to accidentally delete the README.
I kept the application design in the modal to ensure a good UI.
Code pattern
Also, I kept the code pattern used by you, Mauro.
Hope you enjoyed and approve this PR. Thanks!