search

max-christian / homebridge-texecom

A plugin for homebridge (https://github.com/nfarina/homebridge) to integrate Texecom Premier Elite zones into HomeKit
MIT License
27 stars 8 forks source link

Support for connecting over IP (Crestron protocol) #5

Closed max-christian closed 5 years ago

max-christian commented 5 years ago

Adds ip_address and ip_port user configurable parameters. Note that this version requires 'net', but I've not added anything to package.json, don't think it's necessary?

The code supports automatically reconnecting to the alarm if the IP link fails, but I haven't found a way to test this in practice yet.

kieranmjones commented 5 years ago

If you could add the dependency to the package.json as that is what is used for NPM to work out what else needs installing so should probably add it as well including what version is required. It might be worth using the ">= x.x.x" as the method I've used appears to have broken serialport dependency support due to the older version numbers.

Best way to test the alarm link failing is probably to connect Wintex to it as I bet that will kill the connection?

kieranmjones commented 5 years ago

Oh I see you've made changes to the package.json anyway for serialport so maybe you fixed the problem I just discovered a few days ago for me! I had to re-install this plugin and couldn't get it to due to a version problem, had yet to fix it but maybe this has already.

max-christian commented 5 years ago

Yeah, I should probably have done a separate pull request for that.

kieranmjones commented 5 years ago

Don't worry about it, saved me some work this afternoon as I was going to take a look once I had your pull request.

The readme needs updating as well if you don't mind adding documentation for how to configure and use the IP vs serial.

max-christian commented 5 years ago

Yep, will do re. documentation. Any guidance on what line 'net' needs in package.json? I'm thinking maybe it doesn't need one due to being core to node.js, but may well be wrong about that.

kieranmjones commented 5 years ago

Oh if it’s core then no worries as I don’t think it’ll need including, that is just for extra bits that are needed but as you say it’s core so won’t need installing by NPM

anthonyangel commented 5 years ago

Would this work with a Texecom Connect. Can the connect protocol be used in parallel with the Crestron protocol?

kieranmjones commented 5 years ago

Did you get a chance to make those other changes yet max-christian? If you can commit those into this pull request I can then merge it in and release to NPM etc.

anthonyangel - I'm not sure about the Connect, I believe the Connect still can work with the Crestron protocol but they are different. This plugin for Homebridge is for the Crestron protocol on serial and soon IP.

max-christian commented 5 years ago

I’m keen to do the documentation update but it’ll be a few days yet.

@anthonyangel — well worth experimenting with it and the Texecom Connect. I did read something somewhere that sounds like it would work.

kieranmjones commented 5 years ago

How is your documentation update coming along? Would be great to get this merged in, I'm happy to do the documentation if you want to give me a rough outline of the new configuration settings in a comment to this pull request.

max-christian commented 5 years ago

Having a look now...

max-christian commented 5 years ago

That should do it hopefully! Cheers