maxmx03 / dracula.nvim

Dracula.nvim is a port of the popular Dracula colorscheme for Neovim,
MIT License
74 stars 6 forks source link

Small color changes (opinionated) #8

Closed MuhametSmaili closed 1 year ago

MuhametSmaili commented 1 year ago

You did a great job on this theme, kudos to you. Shame that it was not merged directly in the Dracula repository.

I have some suggestions that I think can improve more:

Imrpove the LspReference (cursor hold color)

The

Right now has the color float_bg. I think it would be better if the color is different, something that you can see easily because the dark is not visible. Same in the visual studio code it is not dark it is somehow greenish. Here you can see how I changed the color, I made the color to this: #426646 (I took it with a color picker, maybe they have modified the green color in the visual studio code but not sure, have not checked)

Here is how it is now (left vscode right neovim when you hold cursor): image

Here is how it looks, after changing to the color mentioned above: image

maxmx03 commented 1 year ago

try use blended_green to see how it looks.

local colors = require('dracula.palettes')

dracula.setup {
 override = {
  LspReferenceRead = { bg = colors.blended_green}, -- or colors.selection
  LspReferenceText = { bg = colors.blended_green}, -- or colors.selection
  LspReferenceWrite = { bg = colors.blended_green}, -- or colors.selection
 }
}

i never tested LspReferenceRead because i use plugin like vim-illuminate

MuhametSmaili commented 1 year ago

try use blended_green to see how it looks.

Yes, I think this is the color, you can make also this default if you want it to be the same as code.

Left vscode right neovim:

image

I never tested LspReferenceRead because I use plugins like vim-illuminate

I did not know about that plugin. But I am using the built-in feature which is working fine for me until now.

I consider this issue closed because you have the color in place, it is your choice if you want to make blended_green as default or not. Thank you