search

mbkarle / mind-the-fog

Roguelike JavaScript game--mind the fog!
2 stars 1 forks source link

Split up dungeonAdventure.js #114

Closed akarle closed 6 years ago

akarle commented 6 years ago

It's Been A Long Time Comin

Break it up boys!

The Reasons:

  1. The name is incorrect
  2. Its over 1.6k lines currently
  3. This fits nicely with #26 and the effort to move all the lengthy constructors to a more DB-like format
  4. A lot of repeated code snippets
  5. BIG ONE: Theres truly a lot of stuff that should be better isolated. Like what if we reconsider the game to have two "modes", (1) combat (2) exploration, put them in diff files, and then have different modules accessible to both (inventory, magic tree) that are also in separate files.

Just my thoughts