search

mbland / custom-links

An application for allowing authenticated users to create and dereference custom URLs hosted on a custom domain.
ISC License
7 stars 1 forks source link

Fix "bad Redis" failure case flakiness #173

Closed mbland closed 6 years ago

mbland commented 6 years ago

The previous implementation relied on failure due to a bad Redis host name. This worked most of the time, but while running the test suite in a coffee shop, this test case would timeout and leave a stale redis-server running in the background. Eventually I realized this was because the coffee shop DNS provider was converting failed name lookups to search queries.

This implementation instead relies on connecting to an unused port, and doesn't start a redis-server instance to begin with.

cc: @akashvbabu @mpdatx

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.065% when pulling d265004f41f1697c9db6c421a5caeae1cc6bc75e on fix-smoke-test-flakiness into 1b587f1208ae308599c7f94c0d9d24a039c7a5c0 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.065% when pulling d265004f41f1697c9db6c421a5caeae1cc6bc75e on fix-smoke-test-flakiness into 1b587f1208ae308599c7f94c0d9d24a039c7a5c0 on master.