search

mbland / custom-links

An application for allowing authenticated users to create and dereference custom URLs hosted on a custom domain.
ISC License
7 stars 1 forks source link

Deindex and reindex links #174

Closed mbland closed 6 years ago

mbland commented 6 years ago

Adds deindexLink() and reindexLink() methods to RedisClient, as well as moves the previously private addLinkToSearchSets() to RedisClient.indexLink().

This also renames LinkDb.checkOwnership() to LinkDb.getLinkIfOwner(), which now returns the link info object it uses to validate ownership. This will make dispatching to the RedisClient indexing methods more efficient.

The next PR will do some more refactoring between RedisClient and LinkDb in an effort to better separate concerns.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.003%) to 98.15% when pulling d438c2bfa281d33883baa7860fc38b0ec441e705 on deindex-and-reindex into 74105db3fb5c30815f4e92de02891460c0b48cf9 on master.

mbland commented 6 years ago

I'm performing some refactorings to address the Code Climate warnings, but they're proving to be nontrivial, so I'm going to merge this PR and open a new one with those more significant refactorings.