search

mceSystems / node-jsc

A node.js port to the JavaScriptCore engine and iOS
Other
222 stars 16 forks source link

Linux port #4

Closed Constellation closed 6 years ago

Constellation commented 6 years ago

This is quick changes for Linux port. It breaks existing Windows / iOS ports I think. And some of the changes should not be applied once underlying WebKit is updated. So, please do not merge it right now :)

MCE-KobyBo commented 6 years ago

Thanks! it's great to see that there aren't a lot of changes :) I won't merge the pull request right now, as I also plan on updating WebKit soon (once I finish upgrading the code base to node v10), and need to test everything against Windows and macOS\iOS. But some of the changes could already be merged, which is great.

Constellation commented 6 years ago

Now split patches are landed!