search

mcenderdragon / Futurepack-API

A small Api for the Futurepack
21 stars 4 forks source link

EScanner Rendering crash [1.16.5] #992

Open DamondSword2247 opened 2 months ago

DamondSword2247 commented 2 months ago

Describe the bug Rendering crash when rendering the crafting recipes in the EScanner.

To Reproduce Steps to reproduce the behavior:

  1. Open EScanner.
  2. Navigate to TechTree.
  3. Open any of the item pages and scroll down to the crafting recipe.
  4. Game Crashes.

Screenshots Can't provide as it locks up and crashes.

Additional context Tested in a fresh mod pack for the express purpose of testing only futurepack alone, to try and recreate the EScanner rendering crash I was having in another mod pack. Default graphics settings.

Version Minecraft Version: 1.16.5 Forge Version: 36.2.34 Futurepack Version: Futurepack-1.16.5-31.3.7008

Logs https://pastebin.com/E6Ft7p90

Warentan commented 2 months ago

Having the same issue, same version. After further analysis of the crash report, it looks like (don't take my word for this) the E-scanner is having issues rendering items in the object description. Is there a way to disable this as a workaround?

Update: Currently scavenging through the code to figure out how to shut down recipe rendering.

DamondSword2247 commented 2 months ago

I hope this can be fixed because the escanner is almost useless because of this

Ashwinaaaaaaahdt commented 1 month ago

I hope this can be fixed because the escanner is almost useless because of this

Did you use modpack while playing futurepack

thebloxxer11 commented 1 month ago

Repeatable on: Mod Version 1.18.2-33.0.7544 Forge Version 40.2.10 MC Version 1.18.2

My Crash Report: crash-2024-08-08_07.32.07-client.txt

My perspective: Somehow, the index is going into the negatives (which is not permitted in Java) within one of the methods in this crash report. What I would do is double check the 5 FP methods listed.

Gurasic commented 3 weeks ago

Repeatable on: Futurepack-1.12.2-26.4.89 Forge Version: 14.23.5.2860 MC Version 1.12.2

My Crash Report: https://mclo.gs/Y9CkRHY

Really anoying cuz i cant play the mod now unless i constantly use the wiki

thebloxxer11 commented 2 weeks ago

Further testing resulted in Any research with a recipe that uses a tag instead of an item ID will crash. Tested with an up-to-date Forge in 1.18.2

Somersault0023 commented 2 weeks ago

In that case, my assumptions (or rather main hypothesis) are: something is trying to access an array using the recipe identifier as index, and when using a (I presume string?) tag, the execution explodes.

But I do not know it for sure at all, since I do not know how to debug Minecraft. Do you know how could I debug the mod? I normally use vs code as tool for programming.

Hypermoron commented 15 hours ago

I have submitted a fix for this issue. There is a function in the recipe rendering code that takes the current Unix timestamp in milliseconds and divides by 800. Starting on June 10, 2024, the output value exceeded the Java integer limit. This led to crashes when invalid array indices were produced.

Ashwinaaaaaaahdt commented 5 hours ago

I have submitted a fix for this issue. There is a function in the recipe rendering code that takes the current Unix timestamp in milliseconds and divides by 800. Starting on June 10, 2024, the output value exceeded the Java integer limit. This led to crashes when invalid array indices were produced.

@Hypermoron @DamondSword2247 @thebloxxer11 Sadly the developer can't implement the feature right this year. This is due to lack of time and developers for this. He is alone. If you badly wanted an update for futurepack every time, you can help him to develop the mod. I am looking for five coders to help him. If 5 coders come to help him, then he would do updates on the mods. Besides he is working alone