search

mclemente / about-face

FoundryVTT Module to rotate tokens on move
Other
7 stars 8 forks source link

Token direction resets when changing token status #57

Closed guillaume-gc closed 1 year ago

guillaume-gc commented 1 year ago

When adding a status to a token or hiding it, the token resets to its default position.

Before adding status: image

After adding status (token default position is facing bottom): image

The problems appears even if all my modules are disabled except about-face and libWrapper.

I'm playing on the PF1e system, unsure if it's related.

mclemente commented 1 year ago

I can't reproduce this. Any errors on the console?

tianevitt commented 1 year ago

I can confirm this issue. The best way to reproduce it is to enter a combat state, have the character take some action, and then proceed to the next character. It also seems to happen after a character takes damage.

The above poster summarized it well; it seems to happen when the character status changes in any way.

Love this mod otherwise, so I hop you can figure it out! :)

R0TEAM commented 1 year ago

the same problem as I described in #56 this make the module pointless, as instead of limiting the visible information to a defined arc and facing, it rotates often so the player anyway see all .... and you cant say after this happen (to many situation where this bug is triggered) > please forgot what you have seen ....

guillaume-gc commented 1 year ago

Thanks for the fast reply @mclemente ! Your module is great !

I don't have any error on the console.

Personally I don't need to do anything complex. I just launch Foundry on a PF1e system, rotate a token and then set a status or make a token invisible, and it resets its rotation.

mclemente commented 1 year ago

Thanks to everyone for the inputs. I managed to figure out what was happening and you can just update and that behavior will be gone. There was a bug in About Face that it would try to change the token's rotation on updates that had no rotation in them. So it would return a NaN value and reset to 0.