search

mclemente / about-face

FoundryVTT Module to rotate tokens on move
Other
7 stars 8 forks source link

Adding additional Functionalty #88

Closed Somedude5 closed 8 months ago

Somedude5 commented 8 months ago

Hello! Ive used your module for a couple of months now and I really love it! I thought I would take a crack working with modules and thought of some cool ideas to build on your mod.

Currently The additions I have made include allowing tokens to change their direction arrow whenever they are selected and a user presses t (this also works when groups of tokens are selected), the option for users to turn on targeting with the mousewheel, and the scale and distance of the direction arrow now change based on the scale of the token in addition to size.

So far the only bug I have seen is the size of the direction arrows has become smaller due to the extra scale calculation, but besides that I havent seen any other bugs. Feel free to tweak or use these changes as you see fit but if you do add them id love to be put down as a contributor.

Your module really has added a lot to my games and I hope these changes can help make it even better!

mclemente commented 8 months ago

Hello and thank you for your contribution! The "target at cursor" feature is really cool, but, unfortunately, I'll need some things to be changed or even removed to accept this PR. I've made some comments about them with also some guidance to fix the issue with the distance.

A suggestion for future contributions on any projects: talk with the devs before you put in any work, especially if it isn't a fix for an issue. I could have no use for any of these features and your work would've been for naught.

Somedude5 commented 8 months ago

Ok, thanks for for looking at it, I am still very new to coding much less foundry module coding. I understand your concerns with the PR, I guess I just assumed it was a open source thing lol! Ill be sure to communicate with folks before opening pull requests on their modules.