search

mclemente / about-face

FoundryVTT Module to rotate tokens on move
Other
6 stars 9 forks source link

Rotation Animation Disabling fixes/request #92

Open GambetTV opened 1 month ago

GambetTV commented 1 month ago

I posted this on the other thread, but I couldn't figure out how to re-open the issue so I wasn't sure if you'd get it. I'd like to suggest a couple changes/additions to make this work more how it did in v9/10.

I think it should rotate at the start of movement, not at the end. This will lend itself to much more natural movement for top-down tokens.

It should also disable the rotation animation when you're just using Shift + Mousewheel or Ctrl + Mousewheel or Shift + WASD to change your token's facing.

Mostly I'm just looking for the animation to be disabled in a way where the animation is completely gone, with no delay between you making a chance and seeing the new facing.

Appreciate it!

mclemente commented 1 month ago

I posted this on the other thread, but I couldn't figure out how to re-open the issue so I wasn't sure if you'd get it

You can't re-open issues, just the devs can. I saw your comment and forgot to reply to it, sorry. I've been busy irl these last few days.

I think it should rotate at the start of movement, not at the end. This will lend itself to much more natural movement for top-down tokens.

This is super tricky, I'd have to override the movement, rotate, and then move, which could conflict with every other interaction with the original movement (e.g. other modules', the system's, or foundry's logic).

It should also disable the rotation animation when you're just using Shift + Mousewheel or Ctrl + Mousewheel or Shift + WASD to change your token's facing.

That's doable. To me, it looks super weird having the image just change without an animation, that's why I haven't put it in.

I'm super cautious about overriding Core Foundry to avoid conflicts with other modules or systems.

Disabling the animation was done to avoid making the token's movement way slower than it should've (e.g. mirroring would make moving a single tile take 0.5s), it was never meant to remove the rotation/mirroring animation altogether.

GambetTV commented 1 month ago

No worries about not getting back to me right away! And yeah I tend to agree with you that if you have to override Core Foundry behavior then it's probably not worth it. I was hopeful that it was when you were able to make the previous change!

For me, the problem I have with the animations, even when just Shift + Mousewheeling or Shift + WASDing is that there's just something kind of janky/clunky about them. They feel laggy, if you hold Shift and hit A and D back and forth the token only rotates upward, which often times does not feel natural, and as I use Topdown tokens (like the default Forgotten Adventures tokens) so this movement just feels more artificial. My brain can fool itself into believing the instant change of a token's facing, and having the instant responsiveness of that can lead to a certain level of personality being introduced into the movements, whereas the forced, laggy, programmatically consistent animations is just way more of a net loss for me.