search

mcrescas / veriv

VERIV: This extension provides support for loading and visualizing LDR / HDR images directly inside Vscode. Apart from that, the viewer contains more useful features than the native one included by default
https://marketplace.visualstudio.com/items?itemName=mcrespo.veriv
21 stars 0 forks source link

Bug Prevents Opening of more than 2 images #1

Closed half-potato closed 1 year ago

half-potato commented 1 year ago

When I double click an image to keep it open in the tab bar and attempt to open a second image, the second tab flickers into existence before switching back to the other image tab. If I start with a text editor open and try to open a second image, it yet again flickers to the already open image.

This is a new bug in version v1.0.0 that did not exist in 0.0.5.

Version: 1.74.3 Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534 Date: 2023-01-09T16:57:40.428Z Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 5.15.85-1-MANJARO Sandboxed: Yes

mcrescas commented 1 year ago

Hi,

With the new version, now only one viewer can exists (new images are added to that window so you can compare them directly by using the number keys 1..9 or by clicking the image in the bar that appear at the bottom of the viewer). This allows for quick comparisons between the images and for computing error metrics.

Is this behaviour not working on your side?

Best

half-potato commented 1 year ago

Oh yeah that works. Can you add the double click functionality where it doesn't keep an image open unless you double click?

half-potato commented 1 year ago

Wait, nvm, it doesn't work correctly. I can only open images from the same folder.

mcrescas commented 1 year ago

Hi @half-potato - I have pushed a new version 1.0.1 that allows opening images from different folders in your system. I hope it works for you!

Regarding the double-click functionality: Initially, I wanted to have only one window because of my workflow. Having the two functionalities enabled at the same time seems to be difficult/impossible with the current VSCode API.

half-potato commented 1 year ago

Yes, that works. Thanks!