search

mdbootstrap / material-design-for-bootstrap

Important! A new UI Kit version for Bootstrap 5 is available. Access the latest free version via the link below.
https://mdbootstrap.com/docs/standard/
MIT License
9.34k stars 1.15k forks source link

Disable js waves effect on specific links (nav) #170

Closed ejntaylor closed 5 years ago

ejntaylor commented 6 years ago

Expected behavior

Added MDB to package and now get waves onclick effect on my navigation which creates a background color I do not want. I want no effect. Ideally I want to remove the waves classes from the navigation.

Actual behavior

waves classes are added to the navigation and there is the styling issue on the navigation.

Your working environment and MDB version information

Custom build with JS and relevant SCSS added to theme.

ejntaylor commented 6 years ago

Waves.destroy has been added to version 0.8 of Waves. Outlined here: https://github.com/fians/Waves/issues/159

I can see that MDB is using Waves v0.7.5

Can this be updated this so we can destroy this effect without having to comment out the waves.attach lines.

Thanks

JStrebeyko commented 6 years ago

Hi there @raisonon , Thanks for reaching out! We are currently investigating the possibility of an Waves update - could happen as soon as within the next release, but no promises. Best, Kuba

ejntaylor commented 6 years ago

Fantastic, that would be great as at the moment having waves at 0.75 makes it unusable for us :( Will have to edit the core code. Appreciate the update

JStrebeyko commented 6 years ago

It should be a part of the next (not the nearest-upcoming, but next) agenda. Thanks!

pglejzer commented 5 years ago

I close this issue because https://github.com/fians/Waves/releases there is no v0.8.0 released and we can't update this package for now.