mdbootstrap / material-design-for-bootstrap

Important! A new UI Kit version for Bootstrap 5 is available. Access the latest free version via the link below.
https://mdbootstrap.com/docs/standard/
MIT License
9.34k stars 1.15k forks source link

Separate generated code and variables #175

Closed JoniJnm closed 5 years ago

JoniJnm commented 6 years ago

Expected behavior

Include variables (colors.scss) and don't generate css code

Actual behavior

When I include mdb variables, colors.scss generates css code

Your working environment and MDB version information

Free 4.5.7

Resources (screenshots, code snippets etc.)

I think that the files that define variables should not generate css code. For example I need to include bootstrap and mbd variables:

@import ".../core/bootstrap/functions";
@import ".../core/bootstrap/variables";
@import ".../core/mixins";
@import ".../core/colors";
@import ".../core/variables";

But colors.scss generates css code

@each $color_name, $color in $material-colors {
  .#{$color_name} {
    background-color: $color !important;
  }
}

Can you move this to another file? Maybe to global.scss

mdbootstrap commented 6 years ago

Hi, we will think about a better solution for colors, thank you. Best, Marta

JoniJnm commented 5 years ago

It's done but still exists:

https://github.com/mdbootstrap/bootstrap-material-design/blob/master/scss/core/_colors.scss#L614-L620

You have to move it to global.scss

Martussky commented 5 years ago

Hi, we will. Best, Marta