Git complaining about line endings in SVG files

mdbootstrap / material-design-for-bootstrap

Important! A new UI Kit version for Bootstrap 5 is available. Access the latest free version via the link below.

https://mdbootstrap.com/docs/standard/

MIT License

9.35k stars 1.15k forks source link

Git complaining about line endings in SVG files #215

Closed jurgenhaas closed 4 years ago

jurgenhaas commented 5 years ago

The SVG files in the img/svg directory have CRLF line endings which git always replaces with LFs only. When using these files in your own project where you commit the assets as well, you always get complaints from git at the command line.

Is it possible to cleanup those files and deliver them with LFs only?

mattonit commented 5 years ago

I've added this issue to our TODO list so I hope we'll fix it soon. You can also fix it by yourself and make us a PR so I'll merge it

jurgenhaas commented 4 years ago

@mattonit I'm confused. I have created the PR already over a year ago, it got checked and everything. And just now, @gbujanski closes my PR without merging and at the same time, you're asking me I should create a PR. What's going on?