search

mdittmer / mdn-confluence

2 stars 5 forks source link

Basic support not updated by this tool? #28

Open foolip opened 5 years ago

foolip commented 5 years ago

It appears as though this tool cannot detect the presence of a constructor like Notification to inform the "Basic support" row in MDN compat tables. @mdittmer is that right, a consequence of the interface+api pair model of Confluence?

foolip commented 5 years ago

https://github.com/mdn/browser-compat-data/pull/3326 done manually to work around this.

mdittmer commented 5 years ago

@foolip that is correct. Confluence only deals in interface+API pairs. An "empty interface" will never be detected by Confluence. It would be possible to add a pass or check that looks for "any APIs for interface named name", but that would be a guess at "basic support".

foolip commented 5 years ago

Right, so we could infer basic support from any API on the interface being detected. That would probably be accurate, as there are very few empty interfaces out there...

Do you know off hand whereabouts in the code that would have to be added?

mdittmer commented 5 years ago

Don't recall. I'd have to dive into the code after months away from it. (which I could do, but I don't know off hand).

A good first step might be to grep for distinctive JSON keys used in the BCD a schema. __compat or something like that?

On Tue., Jan. 22, 2019, 3:37 p.m. Philip Jägenstedt, < notifications@github.com> wrote:

Right, so we could infer basic support from any API on the interface being detected. That would probably be accurate, as there are very few empty interfaces out there...

Do you know off hand whereabouts in the code that would have to be added?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mdittmer/mdn-confluence/issues/28#issuecomment-456554143, or mute the thread https://github.com/notifications/unsubscribe-auth/ABsWSNGPQAcz8DPPO-urbW_xZ3vXyVrtks5vF3acgaJpZM4aMrd2 .