search

mdittmer / mdn-confluence

2 stars 5 forks source link

Remove --from-confluence argument and supporting code #32

Closed foolip closed 5 years ago

foolip commented 5 years ago

Continuing to make changes to ConfluenceCompatJsonGenerator has a cost, and adding entirely new APIs to BCD based on Confluence isn't something that is likely useful. The result requires a lot of human edits and review, and should probably be done on a case-by-case basis.

foolip commented 5 years ago

Follow up to https://github.com/mdittmer/mdn-confluence/pull/31#discussion_r255102055.

@mdittmer I have confirmed that web-api-confluence-data-cache/latest in GCS doesn't contain the string "ConfluenceCompatJsonGenerator", is there somewhere else I should check too?

foolip commented 5 years ago

I'll go ahead and merge this and bump the version number to 1.0.0 to mark that it's a breaking change.