search

mdittmer / mdn-confluence

2 stars 5 forks source link

Update the BCD peer dependency to avoid warning #34

Closed foolip closed 5 years ago

foolip commented 5 years ago

With the dependency as it was, npm install in BCD resulted in this warning:

mdn-confluence@0.0.7 requires a peer of mdn-browser-compat-data@git://github.com/mdn/browser-compat-data.git but none is installed. You must install peer dependencies yourself.

Instead depend on 0.0.32, the first release after https://github.com/mdn/browser-compat-data/pull/1723.

foolip commented 5 years ago

This didn't work, trying it with "git://github.com/mdittmer/mdn-confluence.git#peer-dependency" as the dependency in BCD gives the warning "mdn-confluence@0.0.8 requires a peer of mdn-browser-compat-data@^0.0.32 but none is installed" instead.

foolip commented 5 years ago

Sent https://github.com/mdittmer/mdn-confluence/pull/35 instead.