search

mdittmer / mdn-confluence

2 stars 5 forks source link

Remove the BCD peer dependency to avoid warning #35

Closed foolip closed 5 years ago

foolip commented 5 years ago

With the dependency as it was, npm install in BCD resulted in this warning:

mdn-confluence@0.0.7 requires a peer of mdn-browser-compat-data@git://github.com/mdn/browser-compat-data.git but none is installed. You must install peer dependencies yourself.

https://github.com/mdittmer/mdn-confluence/pull/34 was one attempt to resolve this that didn't work, because the two modules don't have a peer relationship, the dependency is rather a plain one.

mdn-confluence should be used from the latest BCD since otherwise conflicts are likely, and package-lock.json in BCD will record the exact commit for reproducability.