search

mdittmer / mdn-confluence

2 stars 5 forks source link

Remove unused BaseImporter.readFile_ #36

Closed foolip closed 5 years ago

foolip commented 5 years ago

The string readFile_ doesn't appear anywhere else in the code.

Hexcles commented 5 years ago

I suppose the nearby writeFile_ is used somewhere. If that's the case, then it makes sense to have readFile_ for parity (for future use), unless there are undesired downsides/side-effects?

foolip commented 5 years ago

That one is used, yes. I usually delete dead code when I find it because I've then spent time trying to figure out where some code is used just to find it isn't, and don't want to repeat it.

But the storage dependency is still used, so I'll abandon this.