search

mdittmer / mdn-confluence

2 stars 5 forks source link

Upgrade @google-cloud/storage to ^2.0.0 #37

Closed foolip closed 5 years ago

foolip commented 5 years ago

This is to fix some npm audit warnings.

The only usage of the package is in BaseImporter.es6.js, but that code isn't exercised when using npm-confluence from browser-compat-data.

foolip commented 5 years ago

@mdittmer how can I exercise the code that depends on this? The real usage is somewhere around generateDataClass() in various files, but I don't know what's actually being written to datastore. Is this all for the data reconciliation UI as opposed to the command line tool?

Hexcles commented 5 years ago

There's a merge conflict in package-lock.json.

foolip commented 5 years ago

@Hexcles fixed