mdittmer / mdn-confluence

2 stars 5 forks source link

There are two versions of foam2 in dependencies #38

Closed foolip closed 3 years ago

foolip commented 5 years ago

Two foam2 dependencies:

The confluence branch is ahead of the mdn-confluence branch: https://github.com/foam-framework/foam2/compare/mdn-confluence...confluence

There many commits and changes, but most are from master.

I tried to depend on the confluence branch in mdn-confluence as well, but there are still two copies. I suspect that when depending on a git repo + branch directly, there's no deduplication/flatting. That there's a node_modules/web-api-confluence-dashboard/node_modules/object-graph-js but no node_modules/object-graph-js also supports this hypothesis.

Don't know how to fix this.

foolip commented 5 years ago

I failed to fix this in https://github.com/mdittmer/mdn-confluence/pull/39. @mdittmer does this matter and how could we fix it?

foolip commented 3 years ago

Fixed by afa7a776da03692d28c2a7dde7fc01a14fb42746.