search

mdittmer / mdn-confluence

2 stars 5 forks source link

Depend on the same branch of foam2 as confluence does #39

Closed foolip closed 5 years ago

foolip commented 5 years ago

https://github.com/mdittmer/confluence/blob/53d37216539948b094063d0f94bf7c986e6fb875/package.json#L34

The confluence branch is ahead of the mdn-confluence branch: https://github.com/foam-framework/foam2/compare/mdn-confluence...confluence

There many commits and changes, but most are from master.

Note that this still doesn't avoid two copies of foam2: https://github.com/mdittmer/mdn-confluence/issues/38

foolip commented 5 years ago

This didn't work. If depending on this branch from browser-compat-data, npm install ends up failing:

> mdn-confluence@1.0.0 build /Users/foolip/src/browser-compat-data/node_modules/mdn-confluence
> node ./scripts/build.js

fs.js:115
    throw err;
    ^

Error: ENOENT: no such file or directory, copyfile '/Users/foolip/src/browser-compat-data/node_modules/mdn-confluence/node_modules/web-api-confluence-dashboard/lib/web_apis/release.es6.js' -> '/Users/foolip/src/browser-compat-data/node_modules/mdn-confluence/public/third_party/confluence/release.es6.js'
    at Object.copyFileSync (fs.js:1702:3)
    at Object.<anonymous> (/Users/foolip/src/browser-compat-data/node_modules/mdn-confluence/scripts/build.js:60:4)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:742:12)
    at startup (internal/bootstrap/node.js:279:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:752:3)