search

mdittmer / mdn-confluence

2 stars 5 forks source link

Remove code and dependencies that aren't needed for BCD #41

Closed foolip closed 5 years ago

foolip commented 5 years ago

This isn't being developed/maintained further, and had some dependencies on web-api-confluence-dashboard. This was found while trying to prune dependencies as much as possible as confluence in turn has a lot of dependencies. The dependency remains, but is now easier to understand.

foolip commented 5 years ago

@jpmedley have you been using the UI, or just the tool through the dependency in BCD? If you're only using it through BCD like I am then I'd like to simplify maintenance a bit with trimming like this.

foolip commented 5 years ago

I'm done with this branch now, each commit pass the basic Travis tests and as mentioned in the last commit message, the output when used in BCD is still the same.

Barring mistakes it should be safe to merge this. https://github.com/GoogleChromeLabs/confluence/pull/347 however will require a little dance to not break BCD even temporarily. Review of both appreciated.

foolip commented 5 years ago

Alright, I put the "little dance" on this branch and re-confirmed that the output when used from BCD is the same. The only further reduction of dependencies possible would be by trimming deps in this repo itself, but not in this PR.

foolip commented 5 years ago

Thanks for review, @mdittmer! I'll merge this and make a new release, hope that works in BCD as my testing suggests it will.

jpmedley commented 5 years ago

I do sometimes use the UI. You are talking about the API Catalog, right?

foolip commented 5 years ago

@jpmedley, no that UI will remain and we'll keep updating with new releases. This PR removed the code supporting the cross-referencing UI with a demo at https://mdittmer.github.io/mdn-confluence/multi.html. I think you've seen it and tried it, but are you still using it?