search

mdrwiega / depth_nav_tools

A set of tools for mobile robot navigation with the depth sensor
http://wiki.ros.org/depth_nav_tools
Other
59 stars 39 forks source link

Update to latest ROS2 Humble & Navigation 2 #19

Closed nakai-omer closed 1 year ago

mdrwiega commented 1 year ago

Thank you for your changes!

mdrwiega commented 1 year ago

Looks like it failed on tests.

nakai-omer commented 1 year ago

@mdrwiega It failed on a test that validated the package.xml file, but probably due to different ros versions it failed, i have updated main.yaml to have the correct ros version

nakai-omer commented 1 year ago

@mdrwiega Hi, could you give me some hints on how to solve the CI failures, seems like it is running on Focal even though the setting is ubuntu-latest, this could cause Humble to not be found.

mdrwiega commented 1 year ago

Hi @nakai-omer. Maybe we should consider a change to ubuntu-22.04 instead of ubuntu-latest, but I'm not sure. Unfortunately, I don't have the environment currently to check it.

nakai-omer commented 1 year ago

@mdrwiega Thanks for the hint, seems like you are right that ubuntu-latest, is actually ubuntu 20.04, I have updated the workflow to ubuntu 22.04, can you please re-run it?

mdrwiega commented 1 year ago

Another possible reason for tests failing at this stage is a version of ros-tooling/setup-ros. I have updated it on the master to v0.3. The tests have passed there. Please try to rebase this branch to master.

mdrwiega commented 1 year ago

Tests are failing now because there is a problem with package.xml file in the cliff_detector package. I have just pushed changes to package.xml. Let's check if that fixes the issue.