mealie-recipes / mealie

Mealie is a self hosted recipe manager and meal planner with a RestAPI backend and a reactive frontend application built in Vue for a pleasant user experience for the whole family. Easily add recipes into your database by providing the url and mealie will automatically import the relevant data or add a family recipe with the UI editor
https://docs.mealie.io
GNU Affero General Public License v3.0
7.09k stars 716 forks source link

[v1.0.0b] - Bulk Importer Fails Silently #1273

Closed stroodle96 closed 2 years ago

stroodle96 commented 2 years ago

First Check

What is the issue you are experiencing?

When trying to use the bulk importer, I see the message that it started but the recipes never show up. When I look at the logs I see the errors below. If I import the recipe one at a time using the normal importer, they import fine. So there are 2 problems here. The big problem here is that there is no notification to the end user that the imports failed at all without looking in the logs. I think there should be notice sent to notifiers or email the user/admin about the failed import. I do have Discord notifier setup with all the notify option selected. The second problem is the bulk importer is throwing errors when the normal URL importer is not.

ERROR: 24-May-22 18:35:12 Failed to create recipe from url: https://www.homechef.com/meals/chile-cumin-carne-asada-with-cilantro-butter ERROR: 24-May-22 18:35:12 (400, {'details': 'BAD_RECIPE_DATA'}) ERROR: 24-May-22 18:35:14 Failed to create recipe from url: https://www.homechef.com/meals/prosciutto-and-mushroom-carbonara-standard ERROR: 24-May-22 18:35:14 (400, {'details': 'BAD_RECIPE_DATA'})

Details Version: v1.0.0b Build: 1092e0ce7c070bbf204ee9ec20b852e690197aef Application Mode: Production Demo Status: Not Demo API Port: 9000 API Docs: Enabled Database Type: sqlite Recipe Scraper Version: 13.33.0

Checks Secure Site: Yes Server Side Base URL: Yes LDAP Ready: No Email Configured: Yes Docker Volumes: success

Deployment

Docker (Linux)

Deployment Details

No response

hay-kot commented 2 years ago

Thanks for the feedback this was half baked for sure!

I've got a working implementation in

That will add a few new features and address your concerns.

  1. It will add a report component below which will show previously done bulk imports and display status You'll be able to click into it and see which recipes failed and review what exception was thrown and a general message.
  2. New toast notifications for successfully starting and import.
  3. There's now a toggle for showing/hiding the category/tag entry section
  4. There's now a bulk add URL dialog so you can past in a list of urls separated by a line and they'll be added to the list.

CleanShot 2022-05-25 at 19 15 14

stroodle96 commented 2 years ago

Awesome, this looks very sleek. Will bulk import status and notifications be sent to notifiers that are setup? Like a discord message that it failed or complete successfully?

hay-kot commented 2 years ago

Not on this go around, but will consider it for a future update.