mealie-recipes / mealie

Mealie is a self hosted recipe manager and meal planner with a RestAPI backend and a reactive frontend application built in Vue for a pleasant user experience for the whole family. Easily add recipes into your database by providing the url and mealie will automatically import the relevant data or add a family recipe with the UI editor
https://docs.mealie.io
GNU Affero General Public License v3.0
5.65k stars 613 forks source link

feat: Data Management from Shopping List #3603

Closed michael-genson closed 1 month ago

michael-genson commented 1 month ago

What type of PR is this?

(REQUIRED)

What this PR does / why we need it:

(REQUIRED)

This PR enables managing data from a shopping list. Namely:

  1. Foods and units can be created from the shopping list (similar to how they can be created from recipes)
  2. Food labels can be changed if the shopping list item uses a different label than the food

This also fixes a visual bug when creating new foods/units on recipes by force-closing the dropdown.

Creating foods from the shopping list (with fixed visual bug): 2024-05-15_11h27_50

Assigning label to food (note that other instances of "apple" are not updated because those items are already set to produce): 2024-05-15_11h28_28

(not pictured: the food "apple" is now re-labeled as "Juice")

Which issue(s) this PR fixes:

(REQUIRED)

Closes https://github.com/mealie-recipes/mealie/discussions/3602

Testing

(fill-in or delete this section)

Manually

michael-genson commented 1 month ago

Yeah I couldn't come up with anything concise enough other than "Copy to Food". Some others:

I was avoiding "permanently" because it seems like a bulky word here, but that could work too. Also maybe adding a tooltip can work?

Kuchenpirat commented 1 month ago

I would suggest going for something shorter like Label Food or Add Label

I think you kinda don't need to reference Food since this is the toggled option. But a tooltip might be a nice middleground, but are not that practical on mobile.

michael-genson commented 1 month ago

Maybe "Set Label" or "Apply Label"? Or "Save Label"? I agree with dropping Food. It's more than "Add" because a Food might already have a Label, just a different one.

michael-genson commented 1 month ago

Updated to "Save Label": image