Closed akrantz01 closed 1 month ago
This issue should be addressed by https://github.com/mealie-recipes/mealie/pull/4002
Happy to look at this one if you think it offers something not addressed by https://github.com/mealie-recipes/mealie/pull/4002, if you could confirm either way
Nope, that's great to see #4002 merged!
What type of PR is this?
What this PR does / why we need it:
Adds a new environment variable called
USE_SECRETS_DIR
that controls whether secrets are loaded from/run/secrets
. It is enabled by default to maintain the existing behaviour.This prevents issues in non-Docker environments where
/run/secrets
may not exist or be readable by the current user.Which issue(s) this PR fixes:
Fixes #3852
Testing
For each scenario, a new dev container environment was created.
/run/secrets
is readable and contains a file forLDAP_SERVER_URL
:LDAP_SERVER_URL
is populated whenUSE_SECRETS_DIR=true
or is not explicitly setLDAP_SERVER_URL
is not populated whenUSE_SECRETS_DIR=false
/run/secrets
is not readable (follow instructions in issue) and contains a file forLDAP_SERVER_URL
:task py
raises the error from the issue whenUSE_SECRETS_DIR=true
or is not explicitly setLDAP_SERVER_URL
is not populated whenUSE_SECRETS_DIR=false
/run/secrets
does not exist:USE_SECRETS_DIR=true
or is not explicitly setUSE_SECRETS_DIR=false