mealie-recipes / mealie

Mealie is a self hosted recipe manager and meal planner with a RestAPI backend and a reactive frontend application built in Vue for a pleasant user experience for the whole family. Easily add recipes into your database by providing the url and mealie will automatically import the relevant data or add a family recipe with the UI editor
https://docs.mealie.io
GNU Affero General Public License v3.0
6.65k stars 683 forks source link

[BUG] - docker image pyproject.toml shows wrong version of mealie? #4026

Open williamkray opened 1 month ago

williamkray commented 1 month ago

First Check

What is the issue you are experiencing?

unsure what the impact of this is, but the pyproject.toml file inside the docker container image for v1.11.0 shows the wrong version of mealie despite the file having been updated in git.

Steps to Reproduce

confirm mealie version with docker compose ps | grep mealie, then compare that to the version string in the container with docker compose exec mealie head /app/pyproject.toml

Please provide relevant logs

$ docker compose ps | grep mealie
apps-mealie-1                   ghcr.io/mealie-recipes/mealie:v1.11.0                                                                                  "/app/run.sh"            mealie                   3 days ago          Up 3 days (healthy)    9000/tcp
apps-mealiepsql-1               postgres:15                                                                                                            "docker-entrypoint.s…"   mealiepsql               3 days ago          Up 3 days (healthy)    5432/tcp
$ docker compose exec mealie head /app/pyproject.toml
[tool.poetry]
authors = ["Hayden <hay-kot@pm.me>"]
description = "A Recipe Manager"
license = "AGPL"
name = "mealie"
version = "1.10.1"

[tool.poetry.scripts]
start = "mealie.app:main"

Mealie Version

docker: ghcr.io/mealie-recipes/mealie:v1.11.0

image

Deployment

Docker (Linux)

Additional Deployment Details

No response

michael-genson commented 1 month ago

Yeah that checks out. This actually used to be totally broken (it was set to 1.0.0b and never updated). Due to how we do releases it will always be slightly behind. Nightly will be correct, though

unsure what the impact of this is

Technically none, though kind of annoying. @boc-the-git not sure if you have any fancy ideas on how to bump the version in the release workflow

michael-genson commented 1 month ago

Also an issue in frontend\package.json

michael-genson commented 1 month ago

Oh wait just kidding it's supposed to be doing this in our release workflow. Well now I'm mildly confused

boc-the-git commented 1 month ago

Oh wait just kidding it's supposed to be doing this in our release workflow. Well now I'm mildly confused

If you're referring to this https://github.com/mealie-recipes/mealie/blob/mealie-next/.github/workflows/release.yml#L71, that's raising the pull request to update it in the repo, not actually updating it for the image that gets built.

In theory this should be updating it for the built image, in init.py.. I haven't verified if that's working. We could do much the same in pyproject.toml