[BUG] - Recipe comments display a username/id rather than the "name" of the user - Githubissues

mealie-recipes / mealie

Mealie is a self hosted recipe manager and meal planner with a RestAPI backend and a reactive frontend application built in Vue for a pleasant user experience for the whole family. Easily add recipes into your database by providing the url and mealie will automatically import the relevant data or add a family recipe with the UI editor

https://docs.mealie.io

GNU Affero General Public License v3.0

7.29k stars 727 forks source link

[BUG] - Recipe comments display a username/id rather than the "name" of the user #4187

Open boc-the-git opened 1 month ago

boc-the-git commented 1 month ago

First Check

[X] This is not a feature request.
[X] I added a very descriptive title to this issue (title field is above this).
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the Mealie documentation, with the integrated search.
[X] I already read the docs and didn't find an answer.
[X] This issue can be replicated on the demo site (https://demo.mealie.io/).

What is the issue you are experiencing?

When you add a comment to a recipe, it displays the username/id, rather than the "name" of the user.

Specifically it comes from here: https://github.com/mealie-recipes/mealie/blob/98ac9cd290b64a16b1ff22723c796a6d13d2fbbd/frontend/components/Domain/Recipe/RecipePage/RecipePageParts/RecipePageComments.vue#L37

Steps to Reproduce

Add a comment to a recipe

Please provide relevant logs

N/A

Mealie Version

Version v1.12.0 Build 0d06494bbfc62fc8a1771a85fd308190891d6167

Deployment

Docker (Linux)

Additional Deployment Details

No response

boc-the-git commented 1 month ago

I raised this as an issue to give anyone a chance to object to this being changed. It straddles bug and feature request IMO.

michael-genson commented 1 month ago

Oh yeah that should definitely be name

shethshlok commented 4 days ago

@michael-genson and @boc-the-git Can you please assign this issue to me? I would love to start my contributions with this issue.

Kuchenpirat commented 4 days ago

You can just go ahead and work on it 👍 There is an open PR (#4295) that is pretty much done besides adding some stuff to our tests

shethshlok commented 4 days ago

Oh, I just saw, that it has been solved, no worries! Thanks for replying!