search

mechatroner / RBQL

🦜RBQL - Rainbow Query Language: SQL-like query engine for (not only) CSV file processing. Supports SQL queries with Python and JavaScript expressions.
https://rbql.org
MIT License
276 stars 13 forks source link

Find a way to fix bulk_read mode for JavaScript version #28

Closed mechatroner closed 3 years ago

mechatroner commented 3 years ago

See the description of the problem in mechatroner/rainbow_csv#19

mechatroner commented 3 years ago

At least we should never enable bulk mode with binary/latin-1 encoding since in this case we never use util.TextDecoder and it should work fine in all environments.

mechatroner commented 3 years ago

Disabled the bulk mode in the cli version. The only thing worth doing is to check if the current env is Electron and/or there is no ICU and gracefully fail with a suggestion to switch encoding.