med-material / VREyeTrackingAccuracyTest

VR Tool to Test the Accuracy of the Pupil Labs Eye Tracking Devices (Unity 2018.2.7f1)
MIT License
2 stars 4 forks source link

MainMenu Config Improvements #10

Closed YoNeXia closed 5 years ago

YoNeXia commented 5 years ago

Improve the MainMenu Interface for the facilitator. Correspond to get the improvements of the issue #5 .

Some options was commented in code, but it was because issue #6 talk about check if right informations are sended in DB. For the interface, do not need it.

The new interface use layout to adapt at all screens. But some times, if you have not the same size of the mockup, the interface are not totally correspond to the mockup.

YoNeXia commented 5 years ago

Hi Bastian!

I finished to do all modifications. I changed commit names and descriptions. And I applied squash modifications.

You have to tell me about comments on my code at this commit 8d9297d. I am waiting your answer. Futhermore, I am waiting your verification about commit changements.

Thanks 😉

YoNeXia commented 5 years ago
  • This commit is making changes to all lines of code in LoggingManager, (removing everything and adding it again?). This might be caused by your IDE? If it is, I suggest that you drop those changes.

It is because I use automatic indentation in Visual Studio, and in this file, VS re-indent all the code. What I do?

YoNeXia commented 5 years ago
  • I would like if your commit message includes explaining that A) the commit introduces new assets required for the main menu design in issue #10 , B) what the purpose of DestroyBlocker and HighlightText is (what they are used for, why you are introducing them).

I add this lines in the commit description :

YoNeXia commented 5 years ago

Hey @bastianilso ! 🙉

I finish to change all commits to match with your rules. Can you check it and give me a feed back?

Thanks. 👌

YoNeXia commented 5 years ago

OK! I change all bugs for the font size, I add the same implementation of Whack A Mole project for int fields, and I rebase all commits to match with your last message.

So please, now it's good 🙏

It is the picture of the mockup and UI in Unity to compare them. 1234

bastianilso commented 5 years ago

:+1: good job @YoNeXia I have no further remarks. In case we find bugs or things need to change, we can revisit it later.