search

med-material / VREyeTrackingAccuracyTest

VR Tool to Test the Accuracy of the Pupil Labs Eye Tracking Devices (Unity 2018.2.7f1)
MIT License
2 stars 4 forks source link

Log default values #14

Closed YoNeXia closed 5 years ago

YoNeXia commented 5 years ago

Hi Bastian! 🐸

I replace all old toggles by booleans inside LoggingManager and StartConfig. So I updated all the code to match with this new implementation. And save the new MainScene updated in the same time, because it use scripts.

bastianilso commented 5 years ago

@YoNeXia Tomorrow, could you please test it with @QuentinDaveau ? Explain to him what issue #12 is about and how you propose to fix it. If Quentin thinks its fine, use the "Rebase and merge" feature in Github, to merge your changes. See screenshot below.

67490498-9dc33a00-f673-11e9-8f96-0fa2bdfdc9d1

QuentinDaveau commented 5 years ago

Everything looks fine to me. Since the only changes made to the code are to restore it to its original state (uncommenting a few lines...) and changing the toggles to booleans, it is quite explicit and it's hard to find any issue with it. To me it's all good for merging 👍

bastianilso commented 5 years ago

Thanks for the review @QuentinDaveau . @YoNeXia this is a fine quick fix for now. One thing we will need to look into in the future for this, is to keep the booleans we dont want to expose in the therapist user interface somewhere else, so they are still controllable for a technician. I will create a separate issue for that.