medbioinf / pia

:books: :microscope: PIA - Protein Inference Algorithms
https://github.com/medbioinf/pia
Other
22 stars 9 forks source link

Major changes in the pia core. #141

Closed ypriverol closed 5 years ago

ypriverol commented 5 years ago

thanks @julianu

julianu commented 5 years ago

There seems to be an dependency problem with org.mozillla.chardet: it cannot be downloaded (neither by travis, nor by myself) using the current POM file. It is a dependency of xxindex, though.

julianu commented 5 years ago

My last comment is probably directly related to this one: https://github.com/PRIDE-Utilities/jmzml/issues/22

codecov-io commented 5 years ago

Codecov Report

Merging #141 into master will increase coverage by 2.56%. The diff coverage is 38.31%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage      52.8%   55.37%   +2.56%     
- Complexity     2316     2331      +15     
============================================
  Files           174      161      -13     
  Lines         17488    16529     -959     
  Branches       2879     2744     -135     
============================================
- Hits           9235     9153      -82     
+ Misses         7290     6376     -914     
- Partials        963     1000      +37
Impacted Files Coverage Δ Complexity Δ
.../protein/inference/SpectrumExtractorInference.java 84.61% <ø> (-0.05%) 65 <0> (ø)
...c/pia/modeller/protein/ProteinExecuteCommands.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../de/mpc/pia/tools/openms/jaxb/DigestionEnzyme.java 44% <ø> (+1.69%) 3 <0> (ø) :arrow_down:
...ler/protein/inference/OccamsRazorWorkerThread.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...mpc/pia/modeller/report/filter/AbstractFilter.java 28.39% <0%> (ø) 28 <0> (ø) :arrow_down:
...ava/de/mpc/pia/modeller/peptide/ReportPeptide.java 57.25% <0%> (ø) 69 <0> (ø) :arrow_down:
.../java/de/mpc/pia/intermediate/piaxml/ScoreXML.java 78.57% <0%> (ø) 8 <0> (ø) :arrow_down:
...c/pia/modeller/report/filter/FilterComparator.java 21.12% <0%> (ø) 1 <0> (ø) :arrow_down:
...c/pia/intermediate/compiler/PIACachedCompiler.java 71.15% <0%> (ø) 28 <0> (ø) :arrow_down:
...java/de/mpc/pia/tools/matomo/PIAMatomoTracker.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09ce46e...94a9cd6. Read the comment docs.