medienbaecker / kirby-modules

Plugin for modular Kirby websites
MIT License
73 stars 7 forks source link

Compatibility with Kirby 4 #39

Closed rantonse closed 7 months ago

rantonse commented 1 year ago

Hi, thanks for a great plugin! I was trying it out with Kirby 4 alpha 6 (https://github.com/getkirby/kirby/tree/4.0.0-alpha.6), and I encountered the following error.

Whoops\Exception\ErrorException thrown with message "Declaration of ModulePage::parents() must be compatible with Kirby\Cms\Page::parents(): Kirby\Cms\Pages"

Stacktrace:
#2 Whoops\Exception\ErrorException in [...]/site/plugins/kirby-modules/lib/models.php:35
#1 Whoops\Run:handleError in [...]/kirby/vendor/filp/whoops/src/Whoops/Run.php:514
#0 Whoops\Run:handleShutdown in [internal]:0
medienbaecker commented 7 months ago

As of Kirby Modules 2.6.0 it is now fully compatible with Kirby 4.