evaluation method seems to assign a new f1 value as a best score without computing f1 value by best_th=0.5

megagonlabs / ditto

Code for the paper "Deep Entity Matching with Pre-trained Language Models"

Apache License 2.0

256 stars 88 forks source link

evaluation method seems to assign a new f1 value as a best score without computing f1 value by best_th=0.5 #28

Closed titsuki closed 2 years ago

titsuki commented 2 years ago

Hi,

In this line, evaluation computes the f1 values by setting th=0.0, th=1.0, th=0.05: for th in np.arange(0.0, 1.0, 0.05):

I found that the f1 value by best_th=0.5 is not computed but this evaluation method assigns a new f1 value without comparing the f1 value by best_th=0.5.

Cheers,

titsuki commented 2 years ago

Sorry, my code reading was wrong. Disregard my issue.