melkati
commented
8 months ago @Coscolin
To make the buzzer code non-blocking and eliminate delays, you can utilize the millis() function for timing and avoid using delay(). Below is the modified code:
uint64_t buzzerStartTime = 0;
uint64_t buzzerStopTime = 0;
void buzzerRedRange() {
Serial.println("[BUZZ] Buzzer RED range");
tone(BUZZER_PIN, toneBuzzerBeep + co2, durationBuzzerBeep);
buzzerStopTime = millis() + durationBuzzerBeep * 1.3;
}
void buzzerOrangeRange() {
Serial.println("[BUZZ] Buzzer ORANGE range");
tone(BUZZER_PIN, toneBuzzerBeep + co2, durationBuzzerBeep);
buzzerStopTime = millis() + durationBuzzerBeep * 1.3;
}
void buzzerLoop() {
if (!activeBuzzer)
return;
if (inMenu) { // Inside Menu stop BEEPING
noTone(BUZZER_PIN);
return;
}
if ((millis() - lastTimeBuzzerBeep >= timeBetweenBuzzerBeep * 1000) || (lastTimeBuzzerBeep == 0)) {
lastTimeBuzzerBeep = millis();
if (co2 > co2RedRange) {
if (belowRedRange || repeatBuzzer) {
wakeUpDisplay();
buzz.once(0, buzzerRedRange);
belowRedRange = false;
}
return;
} else if (co2 < (co2RedRange - BUZZER_HYSTERESIS)) {
belowRedRange = true;
noTone(BUZZER_PIN); // Stop buzzing when below the range
}
if (co2 > co2OrangeRange) {
if (belowOrangeRange || repeatBuzzer) {
wakeUpDisplay();
buzz.once(0, buzzerOrangeRange);
belowOrangeRange = false;
}
return;
} else if (co2 < (co2OrangeRange - BUZZER_HYSTERESIS)) {
belowOrangeRange = true;
noTone(BUZZER_PIN); // Stop buzzing when below the range
}
}
// Stop buzzing after the specified duration
if (millis() >= buzzerStopTime) {
noTone(BUZZER_PIN);
}
}
In this modified code:
- The buzzerStartTime variable is introduced to store the time when the buzzer starts.
- The buzzerStopTime variable is introduced to store the time when the buzzer should stop.
- The buzzerRedRange and buzzerOrangeRange functions now set the buzzerStopTime instead of using delay().
- The main loop checks if it's time to stop the buzzer based on the buzzerStopTime and stops it using noTone() when necessary.
This approach allows the main loop to continue executing while the buzzer functions play without introducing delays.
This is untested code but I think you can get the idea to complete it.
Please, test this (as I don't have a buzzer connected) and if it's working fine, we can change the code.
Coscolin
Thanks @Coscolin is willing to contribute with this feature.
As with most new features, the tasks necessary to implement this are (open to change WIP):