search

meloncholy / vid-streamer

VidStreamer.js: A simple streamer for Flash and HTML5-style videos. Supports HTTP pseudostreaming and works with JW Player's bitrate switching.
http://meloncholy.com
384 stars 64 forks source link

Always provide Accept-Ranges header #17

Closed pamgriffith closed 9 years ago

pamgriffith commented 9 years ago

This change makes the server provide the Accept-Ranges header for every video request, not just the ones that specify a desired range. Internet Explorer 11 (and perhaps 10?) does not attempt to request a range unless it gets this header to an initial request without a range, so pseudo-streaming to IE11 does not work without this change.

vvo commented 9 years ago

@meloncholy any input on this?

meloncholy commented 9 years ago

@pamgriffith-sri Really sorry -- missed this completely when it came in. I've tried your pull request in Chrome (the only browser I have access to for the next ~week) and it seems fine, but obviously that's not the problem you were trying to solve. :) But if you've (both?) tested the change in IE and it works then I'm happy to merge.

@vvo Thanks for the nudge.

For reference, Pam's question on StackOverflow with a bit more info.

pamgriffith commented 9 years ago

I'm not in a hurry, if you want to wait until you can test it yourself. It works for me and seems unlikely to break anything, but response headers are not my forte.

vvo commented 9 years ago

was merged, see https://github.com/meloncholy/vid-streamer/commit/a24a983ec40bf9d9f6154eb3e7adcdfdc0d7630e

vvo commented 9 years ago

And yes it works well and breaks nothing