search

meloncholy / vid-streamer

VidStreamer.js: A simple streamer for Flash and HTML5-style videos. Supports HTTP pseudostreaming and works with JW Player's bitrate switching.
http://meloncholy.com
384 stars 64 forks source link

Naming Issue? 3 #8

Open soulcyon opened 11 years ago

soulcyon commented 11 years ago

http://code.google.com/p/chromium/issues/detail?id=100011

As per the ticket above, if the Content-disposition header has the [comma] symbol, then Chrome will throw a "Duplicate headers received from server" error.

I tried streaming a video file with a [comma] in the filename, and I've reproduced this "bug". For a temporary fix, I modified index.js like this:

info.file = info.path.match(/*...*/).replace(",", "%2C");
soulcyon commented 11 years ago

It seems that info.file variable isn't really used anywhere else, so I modified the variable itself right at the top.

I suggest that the ".replace" fix be implemented only for the Content-Disposition declaration.

meloncholy commented 11 years ago

At least this one isn't my fault. :) I need to leave now, but I'll use your fix tomorrow. Thanks!

soulcyon commented 11 years ago

No problem!

After a bit testing, it seemed you were missing quotes after filename=