Support for @2x/retina tiles (Carto only)

merlos / iOS-Open-GPX-Tracker

GPS Tracker app for iOS + WatchOS. Log your tracks without limits and share them; Open source GPX tracker app written in Swift

http://www.merlos.org/iOS-Open-GPX-Tracker/

GNU General Public License v3.0

605 stars 149 forks source link

Support for @2x/retina tiles (Carto only) #190

Closed vincentneo closed 4 years ago

vincentneo commented 4 years ago

Add another option, which is CARTO's 2x/retina tiles, as I mentioned in #188.

Personally find that Wikimedia tiles work better for this retina style as I experimented in Avenue, than the CARTO ones. Should I add Wikimedia tile support too?

merlos commented 4 years ago

@vincentneo reviewed.

Regarding your question. From https://foundation.wikimedia.org/wiki/Maps_Terms_of_Use#Terms_of_Use_for_Wikimedia_Maps

If you are developing an application that uses the Wikimedia Maps service, you must provide a valid HTTP User-Agent that includes your application, version, and sufficient information to easily contact you (e.g., your email address).

I am not sure we have control over the HTTP User-Agent. How are you doing in the Avenue app?

vincentneo commented 4 years ago

Oops 🤭

That’s bad. Thanks for referring me to that. Did the really dumb thing of not reading that prior...

vincentneo commented 4 years ago

Host: localhost:5678
Accept: */*
Accept-Language: en-sg
Connection: keep-alive
Accept-Encoding: gzip, deflate
User-Agent: Avenue/119 CFNetwork/1126 Darwin/19.5.0 (x86_64)

So I tried to see what user agent I would get by changing a tile server address to localhost and seeing what user agent I'll get (using this https://stackoverflow.com/a/36380210), and it seems like by defaults the app name and build is part of the user-agent Avenue/119.

Can't seem to add a custom one.