search

mesosphere-backup / iot-demo

IoT - It's the thing you want! And so here's a full-stack demo.
Apache License 2.0
62 stars 24 forks source link

Switch to automatically built Docker images. #7

Closed brndnmtthws closed 8 years ago

brndnmtthws commented 8 years ago

cc @kolloch

kolloch commented 8 years ago

Hey Brenden, using mesosphere/* images looks great.

I am a bit skeptical about using ":latest" versions, though. Even if send the group update to Marathon again, Marathon will not try to restart the Apps because it doesn't see any changes. And even if you restart the apps manually, if another version is cached locally, that version is used and not the real latest version. You can avoid the latter by using forcePull but it is still not nice.

It is a bit more work but it is better to explicitly auto-detect the latest available version on deployment and explicit set the version ID. In that case, Marathon will redeploy the application exactly when necessary and caching will do its job in the most favorable way.

What do you think?

Getting the version of a docker image the latest tag of an image doesn't seem to be trivial. https://registry.hub.docker.com/v2/repositories/mesosphere/marathon/tags/ doesn't have it.

But I did something similar here but without auto-builds:

https://github.com/mesosphere/marathon-stuff/blob/master/load-testing/lib/build-image.sh

brndnmtthws commented 8 years ago

I'm with you, but this is not really a production system :) Since it's strictly for demos, I think we can live with just running the latest always by default--and just make sure we don't break it. You can also still override the tags in the config, should you require.

kolloch commented 8 years ago

Ok, what about making the presto image versions also configurable? Otherwise LGTM.