search

metal-crow / Dark-Souls-1-Overhaul

"We're the Project M of Dark Souls!"
Other
89 stars 12 forks source link

Falling off ladder animation randomly triggered #8

Open Rockmih opened 3 years ago

Rockmih commented 3 years ago

I know you dont work on the PTDE edition but i recently updated the mod after playing for years with an older version and i have been experiencing this issue, i checked the .ini file and the ladderfix seems to be deactivated (value 0) so im not sure if this is causing it, im not even sure what triggers the animation it seems to be triggered when walking on slopes/stairs but is not really congruent and i cant replicate it at will.

metal-crow commented 3 years ago

huh, that's an odd one, never seen that before! Yeah if it's value 0 ladderfix is deactivated, so maybe try activating it and seeing if it still happens? Also, can you try disable gesture canceling in the ini and see if that does anything? I've been hearing a few complaints recently that that feature is a bit broken.

Rockmih commented 3 years ago

Its pretty weird yeah the first time it triggered was when i was running up the stairs of the great archives, honestly looked like my character slipped and look like was an intended animation, but after that it started happening in the middle of me fighting, i do noted that it seems to happen if you run out of stamina (just like when you get kicked out of a ladder) AND the last two times i managed to replicate it it was after running out of stamina after a roll attack attempt, but again its really hard to replicate, it doesn't happen all the time.

I added a 0 value after #LadderFixRungIndexOverride= (it had no value befor) and it the bug seems to be less frequent (?) honestly i have no idea if that does anything, but i could only trigger it one time ( in 20 minutes) and before that i could probably trigger it at least one or two times after resting on a bonfire.

Ill disable the gesture cancelling and report if there is any improvement, thanks.

metal-crow commented 3 years ago

I added a 0 value after #LadderFixRungIndexOverride= (it had no value before) and it the bug seems to be less frequent (?) honestly i have no idea if that does anything, but i could only trigger it one time ( in 20 minutes) and before that i could probably trigger it at least one or two times after resting on a bonfire.

Oh, nah that shouldn't change anything. A no value is the same as a 0 value in the ini, and also the # at the front of the line means it's commented out anyway so it won't be read. Basically what that value does it change what rung you get off the ladder at when you're sliding down it (anywhere between the last rung and the 5th rung). So i guess leave that one alone, it shouldn't really make a difference.

SeanPesce commented 3 years ago

Interesting, I always thought this bug was a result of the ladder fix (I’m still not fully convinced it’s not). Can you post your entire configuration here?

Rockmih commented 3 years ago

This is the last config i tried to replicate the bug with

##############################################

DARK SOULS OVERHAUL GENERAL

##############################################

[Dark Souls Overhaul Settings] DisplayNodeCount=1 DisplayPlayTime=1 DimLava=0 GestureCancelling=1 L3Jump=0 OmniRoll=0 # Experimental feature; not recommended LadderFix=0 MultiConsume=1 MultiTribute=1 CustomArchiveFiles= CustomSaveFile= CustomGameConfigFile= MemoryLimit=14286848 DisableLowFpsDisconnect=1 DisableAutoEquip=1 LadderFixRungIndexOverride=0

[Dark Souls Overhaul Keybinds] ToggleMouseInput=0 # Keybind disabled ToggleConsoleLockCamera=0 # Keybind disabled ToggleLavaBrightness=50 # P key ToggleLadderFix=0 # Keybind disabled ToggleItemAutoEquip=0 # Keybind disabled ToggleMultiConsume=0 # Keybind disabled ToggleMultiTribute=0 # Keybind disabled ToggleL3Jump=0 # Keybind disabled ToggleOmniRoll=0 # Keybind disabled ToggleNodeCount=0 # Keybind disabled TogglePlayTime=0 # Keybind disabled BonfireInputFix=0 # Keybind disabled NextSaveFile=27 # Right arrow PrevSaveFile=25 # Left arrow SelectSaveFile=0 # Keybind disabled #############################

HUD Keybinds

ToggleHudCompassRadial=BD # - key ToggleHudCompassBar=0 # Keybind disabled ToggleHudElevationMeter=BE # . key ToggleHudNodeGraph=0 # Keybind disabled ############################# #############################

Anti-Cheat Keybinds

ToggleBinocsTriggerBlockAC=0 # Keybind disabled ToggleDragonTriggerBlockAC=0 # Keybind disabled ############################# #############################

Challenge Keybinds

ToggleChallengeAggressiveAI=0 # Keybind disabled ToggleChallengeBlackPhantomEnemies=4E # N key ToggleChallengeGravelordPhantoms=0 # Keybind disabled DespawnGravelordPhantoms=0 # Keybind disabled #############################

[Game Input] MouseInput=1 ConsoleLockCamera=1

[HUD]

Additional HUD elements from debug build (Note: They're kind of ugly)

CompassRadial=0 CompassBar=0 ElevationMeter=0 NodeGraph=0 ##################################

Weapon Durability Meters

WeaponDurability=1 DurabilityOffsetXL= DurabilityOffsetXR= DurabilityOffsetY=

Default scale = 1.0

DurabilityScale= ##################################

[Challenge Mods] AggressiveAI=0 BlackPhantomEnemies=0 GravelordPhantoms=0

[Challenge Mod Settings]

Maximum distance = 65535

AggressiveAIHearingDistance=50 AggressiveAISmellDistance=50

2 = Black (red) phantom, 1 = white phantom, 0 = normal

BlackPhantomEnemyDrawType=2

#############################################

ANTI-CHEAT

#############################################

WARNING: Disabling anti-cheat services will allow hackers to permanently ruin your characters/save-games.

[Anti-Cheat] BossGuard=0 NpcGuard=1 TeleBackstabProtect=1 BinocsTriggerBlock=1 DragonTriggerBlock=1

############################################## ######## DEBUG ######### ############################################## [Dark Souls Overhaul Debug] MonitorBdtFiles=0 MonitorBhdFiles=0 MonitorSaveFile=0 IoMonitorFilter=

#############################################

DLL SETTINGS

############################################# [Advanced Settings]

To chain another d3d9.dll wrapper after this one, enter the filename here. The wrapper will be loaded in place of the real d3d9.dll

d3d9Chain=

d3d9Chain=d3d9_dspw.dll

d3d9Chain=d3d9_sweetfx.dll

d3d9Chain=reshade\d3d9.dll

Enter any number of generic DLL filenames here; you can add more "GenericDLL#=" entries, as long as the #s are consecutive.

(THIS IS FOR GENERIC DLLS AND OVERLAY PLUGINS, NOT FOR WRAPPER DLLS)

GenericDLL0=DS_Overhaul.dll GenericDLL1= GenericDLL2= GenericDLL3=

If enabled, this setting will offset the overlay to avoid clipping with the DSPW overlay

DspwOverlayAdjustment=0

#############################################

CONSOLE SETTINGS

############################################# [Console] FontSize=12 Prompt="> " PromptElementUsername=0 PromptElementHostname=0 PromptElementWorkingDir=0 Caret=_ UseBoxCaret=0 CaretBlinkDelay=500 # Milliseconds BorderWidth=3 OutputLines=25 ShowAutoCompletePreview=1 AutoCompleteLimit=5 ShowMouseCursor=1 MouseCursorSize=16 InputEcho=1 OutputStream=1

If set to 1, a CMD window displaying the in-game CLI output will open when the game is launched

ExternalOutputWindow=0

#############################################

OVERLAY SETTINGS

############################################# [Keybinds] ToggleOverlay=4D # M key ToggleInfoBar=0 # Keybind disabled ChangeOverlayTextPosition=0 # Keybind disabled ChangeOverlayTextStyle=0 # Keybind disabled

OpenConsole=C0 # ~ key (aka `)

[Preferences]

1=Enabled, 0=Disabled

EnableOverlay=1 DisplayFPS=0 DisplayFrameCount=0 DisplayTime=0 DisplayDate=0 OverlayTextSize=12 EnableAudioFeedback=0

Accepted values are LEFT, CENTER, or RIGHT

OverlayTextHorizontalPosition=LEFT

Accepted values are TOP, CENTER, or BOTTOM

OverlayTextVerticalPosition=BOTTOM

Accepted values are OUTLINE, SHADOW, or PLAIN

OverlayTextStyle=OUTLINE

[Developer Preferences] EnableVerboseOutput=0

[Developer Keybinds] PrintTestMessage=0 # Keybind disabled ToggleAudioFeedback=0 # Keybind disabled ToggleVerboseOutput=0 # Keybind disabled IncreaseTextSize=0 # Keybind disabled DecreaseTextSize=0 # Keybind disabled ResetTextSize=0 # Keybind disabled

For a list of virtual key codes:

https://docs.microsoft.com/en-us/windows/desktop/inputdev/virtual-key-codes

Check out the source code for the Overhaul mod on GitHub:

https://github.com/metal-crow/Dark-Souls-1-Overhaul/

Check out the source code for the DirectX 9 overlay on GitHub:

https://github.com/SeanPesce/Direct3D9-Overlay

(anywhere between the last rung and the 5th rung)

Its odd because i have been sliding down ladders a lot more lately and haven't fell out the world a single time. I do noticed that in tomb of giants bonefire if i silde down my character would indeed get off the ladder earlier stay still in the air for a little floating and then fall to thye ground.

SeanPesce commented 3 years ago

The LadderFix setting fixes the bug that would cause the player to clip through the map when sliding down the two ladders seen in this video at 0:20. This bug only occurs when DSFix is installed and the framerate is unlocked. IIRC, the ladder fix code only activates in the two world zones with those ladders, so to replicate the bug you would need to:

When your stamina runs out in that scenario, I'd expect the bug to be triggered ~100% of the time if the ladder fix is enabled, but not when LadderFix=0. Would you be able to test it and confirm whether it happens with and/or without the ladder fix disabled?

Rockmih commented 3 years ago

Can 100% confirm the bug happens on Tomb of the giants just as you explained AND it also triggers if i slide down the ladder just outside the great archives (the one going to the crystal cave) and i was able to replicate every single time too, as for now i just tested those two ladders but i feel all the ladders on the great archives trigger the bug too. And i double checked the .ini too and the ladder fix remains at 0 value.

SeanPesce commented 3 years ago

Okay, that’s definitely a problem. Can you do me a favor and check the status of the ladder fix at runtime? While in-game, open the console (default key bind is ~ or `) and use the ladder_fix command.

EDIT: If the output says it's enabled, try using the command ladder_fix 0 to disable it; this might be a temporary workaround for now.

Rockmih commented 3 years ago

The ladder fix is enabled when launching the game, disabling it works as intended ill attach a screenshot, thanks. https://i.imgur.com/m6ipmZt.jpg

SeanPesce commented 3 years ago

The problem (besides the underlying bug itself) seems to be twofold:

Unfortunately it's unclear whether I'll have time to do the reverse engineering required to fix the falling animation bug, but I should definitely have time to fix the configuration problem sometime soon.

Rockmih commented 3 years ago

Thank you! for now the disabling it from the console does the trick ill wait for the fix, thanks for your work. \o/