Closed ronaldtse closed 2 years ago
I could have sworn I already had code to do this automatically, but I can't find it, so I'll reintroduce it.
Reopening to track progress.
main
branch with latest released gemsThe French bibliography is empty and it shows.
The English bibliography is not empty (regression of #181 ):
Blocked by https://github.com/metanorma/metanorma-bipm/issues/182
Released gem does not include this commit. Rereleasing.
No, not rereleasing. That code was authored after release.
Ronald, pull isodoc from github. I did confirm this my side last week. And spurious bug reports are an abuse of my limited time.
Well, this is half fixed.
The "bibliography" sections are gone, but the pages for bibliography still exist:
From @opoudjis :
There's no heading, but there is a page number.
<bibliography><references id="_bibliography_si-brochure-en" normative="false" obligation="informative" hidden="true" displayorder="13">
PDF generation needs to respect the hidden attribute not only in not generating headings, but also not generating empty pages
Apparently this is a PDF issue? @Intelligent2013 can you help check? Thanks.
@ronaldtse yes, the empty bibliography should be ignored. Will fix.
@ronaldtse BIPM xslt updated, but doesn't updated in metanorma-bipm due the error:
Error: The format of 'metanorma-ci' is not a valid email address with display name
(https://github.com/metanorma/mn-native-pdf/runs/7295258351?check_suite_focus=true)
Thanks @Intelligent2013 , @CAMOBAP is now investigating the action failures at mn-native-pdf
@CAMOBAP @Intelligent2013 confirm this is completed. Thank you!
(This is a follow up from #181 )
collection_en.pdf:
collection_fr.pdf:
collection.pdf: French:
English: