metanorma / bipm-si-brochure

SI Brochure edition 9, semantic encoded version (WARNING: DRAFT)
3 stars 0 forks source link

When collection omits all bibliographic items, the empty bibliography should not be rendered #182

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

(This is a follow up from #181 )

collection_en.pdf:

image

collection_fr.pdf:

Screenshot 2022-07-06 at 9 23 02 AM

collection.pdf: French:

image

English:

image
opoudjis commented 2 years ago

I could have sworn I already had code to do this automatically, but I can't find it, so I'll reintroduce it.

ronaldtse commented 2 years ago

Reopening to track progress.

Using main branch with latest released gems

The French bibliography is empty and it shows.

Screenshot 2022-07-12 at 2 22 12 AM

The English bibliography is not empty (regression of #181 ):

Screenshot 2022-07-12 at 2 22 21 AM

Using git gems

Blocked by https://github.com/metanorma/metanorma-bipm/issues/182

opoudjis commented 2 years ago

Released gem does not include this commit. Rereleasing.

opoudjis commented 2 years ago

No, not rereleasing. That code was authored after release.

Ronald, pull isodoc from github. I did confirm this my side last week. And spurious bug reports are an abuse of my limited time.

ronaldtse commented 2 years ago

Well, this is half fixed.

The "bibliography" sections are gone, but the pages for bibliography still exist:

image Screenshot 2022-07-12 at 12 36 42 PM

From @opoudjis :

There's no heading, but there is a page number.

<bibliography><references id="_bibliography_si-brochure-en" normative="false" obligation="informative" hidden="true" displayorder="13">

PDF generation needs to respect the hidden attribute not only in not generating headings, but also not generating empty pages

Apparently this is a PDF issue? @Intelligent2013 can you help check? Thanks.

Intelligent2013 commented 2 years ago

@ronaldtse yes, the empty bibliography should be ignored. Will fix.

Intelligent2013 commented 2 years ago

@ronaldtse BIPM xslt updated, but doesn't updated in metanorma-bipm due the error: Error: The format of 'metanorma-ci' is not a valid email address with display name (https://github.com/metanorma/mn-native-pdf/runs/7295258351?check_suite_focus=true)

ronaldtse commented 2 years ago

Thanks @Intelligent2013 , @CAMOBAP is now investigating the action failures at mn-native-pdf

ronaldtse commented 2 years ago

@CAMOBAP @Intelligent2013 confirm this is completed. Thank you!