search

metanorma / iso-10303-templates

Annotated EXPRESS rendering templates for ISO 10303
0 stars 0 forks source link

Updates/additions to templates #16

Closed manuelfuenmayor closed 4 months ago

manuelfuenmayor commented 4 months ago

Fixes https://github.com/metanorma/iso-10303-templates/issues/11

TRThurman commented 4 months ago

The name of the .adoc file is suspicious. The terms used in modules and resources are different. I would have expected module_annex_change_history.adoc to be in the context of modules; and an equivalent .adoc file for resources. If there is only one .adoc file that handles both use cases of modules and resources, it should be so named.

ronaldtse commented 4 months ago

@TRThurman I believe @manuelfuenmayor will create a new change history for resources.

manuelfuenmayor commented 4 months ago

@ronaldtse @TRThurman sorry. Yes, there is a mistake in the name. There should be "module_annex_change_history.adoc" for module documents, and "resource_annex_change_history.adoc" for resource documents. I'll fix that.

manuelfuenmayor commented 4 months ago

Fixed in https://github.com/metanorma/iso-10303-templates/pull/18