metrumresearchgroup / Torsten

library of C++ functions that support applications of Stan in Pharmacometrics
BSD 3-Clause "New" or "Revised" License
52 stars 11 forks source link

[BUG] steady state functor uses default integrator controls params #16

Closed yizhang-yiz closed 4 years ago

yizhang-yiz commented 4 years ago

Description

Currently integrators within SS adaptor uses default constructor, so the effect of ODE controls do not propagate into steady state functor definition.

Example

In PMXOdeFunctorSSAdaptor definition there's

    operator()(const Eigen::Matrix<T0, Eigen::Dynamic, 1>& x,
               const Eigen::Matrix<T1, Eigen::Dynamic, 1>& y,
               const std::vector<double>& x_r,
               const std::vector<int>& x_i,
               std::ostream* msgs) const {
//....
      const PMXOdeIntegrator<It> integrator_;

Expected Output

The integrator_ should use pmx_solve_xxx's ODE control param for construction.

Current Version:

v0.87.1

yizhang-yiz commented 4 years ago

Resolved in math https://github.com/metrumresearchgroup/math/pull/36