search

metrumresearchgroup / Torsten

library of C++ functions that support applications of Stan in Pharmacometrics
BSD 3-Clause "New" or "Revised" License
52 stars 11 forks source link

Add enhancement evid8 #21

Closed csetraynor closed 3 years ago

csetraynor commented 4 years ago

This commit references to usage of EVID issue #9 . It is a minimal change in event_history.hpp and even_solver.cpp to define is_replace to implement EVID =8 as it is implemented in mrgsolve. See https://mrgsolve.github.io/user_guide/input-data-sets.html

yizhang-yiz commented 4 years ago

Thanks for the submission. I'll review it next week.

yizhang-yiz commented 4 years ago

@csetraynor could you add a unit test? You can take a look at https://github.com/metrumresearchgroup/Torsten/blob/master/cmdstan/stan/lib/stan_math/test/unit/math/torsten/events_test.cpp for how some of the similar event-related implementations are tested. In general, as in Stan development, we try to test everything added to the code.

Sorry for being so late on review.