metrumresearchgroup / Torsten

library of C++ functions that support applications of Stan in Pharmacometrics
BSD 3-Clause "New" or "Revised" License
52 stars 11 forks source link

[BUG] bioavailability calculation error on MacOS with LLVM 15 #50

Closed yizhang-yiz closed 6 months ago

yizhang-yiz commented 6 months ago

Description

From a user report I was able to trace the error to bioavailability calculation at

https://github.com/metrumresearchgroup/Torsten/blob/2d9076fe99a2f6dfc1ed0d40657fcc3e438a306d/cmdstan/stan/lib/stan_math/stan/math/torsten/ev_manager.hpp#L251

Example

Expected Output

Pass all tests and example models run w/o issue.

Current Version:

v0.89.0

yizhang-yiz commented 6 months ago

@billgillespie could you check if https://github.com/metrumresearchgroup/Torsten/tree/v0.91.0rc3 fixes the MacOS issue? Thanks.

billgillespie commented 6 months ago

@yizhang-yiz, The pk2cpt ran successfully with v0.91.0rc3 using clang 15.0.0 on my MacBook Air running macOS 14.3.1...

yizhang-yiz commented 6 months ago

@jburos, could you give another try of the release candidate https://github.com/metrumresearchgroup/Torsten/tree/v0.91.0rc3 ? Thanks.

jburos commented 6 months ago

@jburos, could you give another try of the release candidate https://github.com/metrumresearchgroup/Torsten/tree/v0.91.0rc3 ? Thanks.

Hi @yizhang-yiz, thanks so much for fixing this. Both this example and one of my own work perfectly on my M3 mac computer, using the standard LLVM+clang setup.

yizhang-yiz commented 6 months ago

Thanks @jburos !