mevCJ / logo-packer

Adobe Illustrator extension that generates multiple logo variations and export them automatically
23 stars 2 forks source link

Expanded export functionality updates #10

Closed schroef closed 1 year ago

schroef commented 1 year ago

Please note, my index still has the old layout compared to your version. When merging, choose to adjust it again or keep it like this. Perhaps i should adjust the layout, im not 100% convinced about how the destination folder part looks. The input showing the path is very narrow

[0.5.9] - 2022-12-09

Added

Fixed

Others

[0.5.8] - 2022-12-08

Fixed

Added

[0.5.7] - 2022-12-06

Added

[0.5.6] - 2022-12-01

Added

[0.5.5] - 2022-11-30

Added

[0.5.4] - 2022-11-29

Added

[0.5.3] - 2022-11-24

Added

[0.5.2] - 2022-11-23

Fixed

[0.5.1] - 2022-11-22

Fixed

[0.5.0] - 2022-11-21

Fixed

Added

[0.4.9] - 2022-11-14

Added

[0.4.8] - 2022-11-11

Fixed

mevCJ commented 1 year ago

@schroef thanks for the contribution! I've updated the layout. The reason of putting the folder icon beside destination input is because it lets user to be able to find the button more easily as elements with the same function are grouped together.

I've also updated the cmyktopms.jsx from jsxbin to jsx and fixed some bugs in that script.

schroef commented 1 year ago

Did it had bugs? Didn't noticed that. Where you able to decipher the jsxbin file easily?

One side note. With he new illustrator version lacking pms libraries. I'm not sure we are allowed to do this now. Though on hand, we just add a name a lab value. They don't own lab values. But perhaps i need toch this better

Please don't use the converted jsx of cmyktopms. There was a reason i coded it

mevCJ commented 1 year ago

I used a script here https://github.com/AngeloD2022/jsxbin_decompiler

The script only changes the color of the first item in a groupItems object. I've added another condition for groupitems so that it changes everything in a group.

Just wondering, where did you get the script from?

schroef commented 1 year ago

I tested it many times and worked fine for me with group items.

I've made script myself using a combination of different scripts. I've used parts of code to make this functionality possible with just a single script. The original script used an extra ai file which had stored all pms colors, but i found that cumbersome. So i packed all colors and color values in a single script. It would also only do the swatches inside a file, it didn't do a selected item. I used a different script so that it would itterste over parts inside a selected group. That worked fine on my end.

I prefer we keep this on jwxbin mode

schroef commented 1 year ago

I see what you meant with the group issue. I always tend to group a logo. So basically nothing was changed in the cmyktopms, i see you reordered some lines. But please keep it in jsxbin format!