search

mevCJ / logo-packer

Adobe Illustrator extension that generates multiple logo variations and export them automatically
22 stars 2 forks source link

[BUG] erratic behaviour of the plugin #15

Open MrGGGabriel opened 2 months ago

MrGGGabriel commented 2 months ago

OS:

Describe the bug The plugin work strangely, and have random renders.

To Reproduce Example 1 of a strange behavior:

  1. Drag & drop a logo
  2. Choose Digital and Fullcolor only, apply 40 px margin.
  3. Message appear "Artwork is not the same color scheme" > Choosing right color scheme (or leaving the same)
  4. Logo is generated without margin
  5. If I set margins on the generated artboard, logo is not exporting anymore

Example 2 of a strange behavior:

  1. Drag & drop a logo
  2. Choose Print and Fullcolor + Black and White
  3. When generat message appear "Object "Execute script" is not available at the time".
  4. By clicking ok, artboard are generated "broken".
  5. Restarting illustrator and executing same steps may result on a good export.

The thing is that the plugin is working randomly. Maybe it's my setup ? I have activated Rosetta and debug mode.

schroef commented 2 months ago

Can you show screen grabs of how the logo document looks when you have manually added the margin. I wonder why it's not exporting. Or perhaps share that document so I can check my self.

For the first issue, I'll try a run using a logo and using your steps to reproduce it.

Ps in the context menu of the panel (flyout menu), can you check which version you are using

MrGGGabriel commented 2 months ago

Hi ! Thanks for your reply :-) Ok I can take a video screenshot to help you find the problem. I'll do it ASAP !

Le jeu. 30 mai 2024 à 14:33, schroef @.***> a écrit :

Can you show screen grabs of how the logo document looks when you have manually added the margin. I wonder why it's not exporting. Or perhaps share that document so I can check my self.

For the first issue, I'll try a run using a logo and using your steps to reproduce it.

— Reply to this email directly, view it on GitHub https://github.com/mevCJ/logo-packer/issues/15#issuecomment-2139457396, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7EIWRUHC2CKSBPKGZPBGTZE4MDHAVCNFSM6AAAAABIQTFN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZZGQ2TOMZZGY . You are receiving this because you authored the thread.Message ID: @.***>

-- [image: facebook] https://www.facebook.com/GGGabrielPES [image: linkedin] https://www.linkedin.com/in/gabrielpes/ [image: instagram] https://www.instagram.com/mrgggabriel/ Gabriel PES

Graphiste / Webdesigner [image: mobilePhone] +336 03 93 40 88 <+336+03+93+40+88> [image: website] www.gggabriel.fr <//www.gggabriel.fr>

schroef commented 1 month ago

ps you don't have to drag and drop the logo. It also works when you have a logo selected, then press generate. You need to set all settings before you drag and drop a logo ontp the panel.

Try both methods, it could be drag and drop causes the issue. Last time I checked it was working.

schroef commented 1 month ago

Okay, i just tested your first issue. I see there is an issue when only FullColor is selected I got that fixed on my side. Ill try to upload it tomorrow to GitHub when i have more time. So you test it.

Now your second issue also works fine on my side, i think that was also related to the drag and drop not working

Seems something with the code to copy the logo using evalScript doesnt working properly in newer versions. Im ow using an extra command inside that loop when its waiting for a result. This now works on my side

EDIT 2 I just realised something. Can you try to drag and drop a logo without selecting it first. I think perhaps this is causing the issue. In the code it uses select all on artboard. I just now noticed when i first select it manually, than drag and drop. It doesnt generate properly using drag and drop. When i dont select anything on the artboard, than use drag and drop, it does work

https://github.com/mevCJ/logo-packer/assets/6923008/9a034bf7-97fc-48d3-9091-60824967cb8e

After testing more and more, it seems the drag and drop is not that stable. Perhaps we should take it out.

MrGGGabriel commented 1 month ago

Hi !

That's great ! Thanks for your fast answer and reliability 🙌🏼 I didn't had time to make a video but I'll try on monday.

Hava a noce week-end !

Le ven. 31 mai 2024, 19:46, schroef @.***> a écrit :

Okay, i just tested your first issue. I see there is an issue when only FullColor is selected I got that fixed on my side. Ill try to upload it tomorrow to GitHub when i have more time. So you test it.

Now your second issue also works fine on my side, i think that was also related to the drag and drop not working

— Reply to this email directly, view it on GitHub https://github.com/mevCJ/logo-packer/issues/15#issuecomment-2142717248, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR7EIWSEJFVCT3UZ3YPIMADZFCZQDAVCNFSM6AAAAABIQTFN52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSG4YTOMRUHA . You are receiving this because you authored the thread.Message ID: @.***>

schroef commented 1 month ago

Though I first need to make a pull request. Than the dev of this GitHub needs to upload a new version to adobe and than we need to wait for approval, that takes time. My own GitHub wil have a working version but you need to do manual install. Which is a bit more work.

I'll do some more test tomorrow if I find time. Right now I see drag and drop working randomly. It's kinda weird

schroef commented 1 month ago

I have a branch where it now works. Took some time to pinpoint it, but i believe it got it now. You do need to install this manually according to the readme.md file https://github.com/schroef/logo-packer/blob/fix_dragndrop

I also found some other issues, im still working on those

schroef commented 1 month ago

@MrGGGabriel

Have you tried my version yet?