search

mfbonfigli / gocesiumtiler

A Cesium.js point cloud 3D tiles generator from LAS files written in Golang
GNU Lesser General Public License v3.0
185 stars 39 forks source link

Bugfix/issue 12 fix executable path #14

Closed taozywu closed 3 years ago

taozywu commented 3 years ago

RT

mfbonfigli commented 3 years ago

Thanks for the effort :)

However the automated build failed with these errors:

tools/io.go:6:2: imported and not used: "path/filepath"
tools/io.go:7:2: imported and not used: "runtime"
tools/io.go:8:2: imported and not used: "strings"

In go the program won't compile if there are unused imports. You should just remove the imports to have the build pass, however the tests will most likely fail anyway.

Your approach in theory works, but in practice it does not work when you run tests because the workdir for tests is test/unit and not the root :( Since we need tests to ensure the maintainability of the code we have to come up with a solution that works both when tests are run and when the actual program is running.

I'm leaving this open for now if you want to propose another approach. Otherwise you can just close it or I will do it in a few days.

mfbonfigli commented 3 years ago

Closing this one, feel free to submit a new one if you want.